Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6195: Made URL_ALIAS_ROUTE_NAME calls inside MVC\Symfony\Routing\UrlAliasRouter static #246

Merged
merged 2 commits into from
Jul 24, 2023
Merged

IBX-6195: Made URL_ALIAS_ROUTE_NAME calls inside MVC\Symfony\Routing\UrlAliasRouter static #246

merged 2 commits into from
Jul 24, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Jul 17, 2023

Question Answer
JIRA issue IBX-6195
Type bug
Target Ibexa version v4.0
BC breaks no

Classes that extend the core's UrlAliasRouter should properly handle their own route names (like https://github.com/ibexa/compatibility-layer/blob/main/src/lib/Routing/UrlAliasRouter.php).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@barw4 barw4 added Bug Something isn't working Ready for review labels Jul 17, 2023
@barw4 barw4 requested review from ViniTou and a team July 17, 2023 11:16
@barw4 barw4 self-assigned this Jul 17, 2023
alongosz
alongosz approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally at some point we should refactor this to have an interface or proper abstract instead of relying on a const.
+1 of course for the quick fix.

@alongosz alongosz requested a review from a team July 17, 2023 12:02
@konradoboza konradoboza requested a review from a team July 17, 2023 12:03
ViniTou
ViniTou approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please, do the same for \Ibexa\Core\MVC\Symfony\Routing\UrlWildcardRouter

@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mnocon
mnocon approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue no longer occurs, references to ez_urlalias and ibexa.url.alias are working correctly - approved!

@alongosz alongosz merged commit b475a03 into 4.5 Jul 24, 2023
22 checks passed
@alongosz alongosz deleted the ibx-6195-UrlAliasRouter-static-route-name branch July 24, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@barw4 barw4

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@barw4 @alongosz @mnocon @ViniTou @konradoboza @kisztof @mikadamczyk